[strongSwan-dev] [PATCH] libcharon/vici: install libvici.h header

[Matt Weber]

From: Paresh Chaudhary <***@rockwellcollins.com>

Install "libvici.h" if --with-dev-headers is configured.
Strongswan currently installs other development headers using
this method.

The libvici plugin provides a stable low-level C API to
exchange messages using the VICI protocol. This allows a user
to write standalone applications based on 'libvici' functions,
'libvici.h' header file is required to link all functions at
compile time.

Original discussion and commit:
https://wiki.strongswan.org/projects/strongswan/repository/revisions/01c2b62362df88a03c53b748bb4e88631410f326

Signed-off-by: Paresh Chaudhary <***@rockwellcollins.com>
Signed-off-by: Matt Weber <***@rockwellcollins.com>
---
src/libcharon/plugins/vici/Makefile.am | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/libcharon/plugins/vici/Makefile.am b/src/libcharon/plugins/vici/Makefile.am
index e8bcdba..6b11ff1 100644
--- a/src/libcharon/plugins/vici/Makefile.am
+++ b/src/libcharon/plugins/vici/Makefile.am
@@ -42,7 +42,12 @@ libvici_la_SOURCES = \
vici_message.c vici_message.h \
vici_builder.c vici_builder.h \
vici_cert_info.h vici_cert_info.c \
- libvici.c libvici.h
+ libvici.c
+
+if USE_DEV_HEADERS
+vici_includedir = ${dev_headers}
+nobase_vici_include_HEADERS = libvici.h
+endif

libvici_la_LIBADD = $(top_builddir)/src/libstrongswan/libstrongswan.la

[Matthew Weber]

All,

On Thu, Sep 20, 2018 at 10:09 AM Matt Weber

Post by Matt Weber
Install "libvici.h" if --with-dev-headers is configured.
Strongswan currently installs other development headers using
this method.
The libvici plugin provides a stable low-level C API to
exchange messages using the VICI protocol. This allows a user
to write standalone applications based on 'libvici' functions,
'libvici.h' header file is required to link all functions at
compile time.
https://wiki.strongswan.org/projects/strongswan/repository/revisions/01c2b62362df88a03c53b748bb4e88631410f326

I should have asked this question when sending that patch. That
commit was never pulled into their master and is currently hanging out
on a libvici-dev-header branch. Is there any reason it couldn't be
merged in?

This discussion seemed to support adding this feature
https://lists.strongswan.org/pipermail/users/2015-September/008777.html

Matt

[Matthew Weber]

Andreas, all,

On Thu, Sep 20, 2018 at 3:01 PM Matthew Weber

Post by Matthew Weber
All,
On Thu, Sep 20, 2018 at 10:09 AM Matt Weber

Post by Matt Weber
Install "libvici.h" if --with-dev-headers is configured.
Strongswan currently installs other development headers using
this method.
The libvici plugin provides a stable low-level C API to
exchange messages using the VICI protocol. This allows a user
to write standalone applications based on 'libvici' functions,
'libvici.h' header file is required to link all functions at
compile time.
https://wiki.strongswan.org/projects/strongswan/repository/revisions/01c2b62362df88a03c53b748bb4e88631410f326

I should have asked this question when sending that patch. That
commit was never pulled into their master and is currently hanging out
on a libvici-dev-header branch. Is there any reason it couldn't be
merged in?
This discussion seemed to support adding this feature
https://lists.strongswan.org/pipermail/users/2015-September/008777.html

Wondering what direction I should take with this patch, I'm making
this update for a distro's (Buildroot) version of Strongswan and would
like to merge this upstream if possible. If not, I can document why
and we'll carry the patch.

Thanks!
Matt

[Tobias Brunner]

Hi Matt,

Post by Matthew Weber
Wondering what direction I should take with this patch, I'm making
this update for a distro's (Buildroot) version of Strongswan and would
like to merge this upstream if possible. If not, I can document why
and we'll carry the patch.

libvici is mostly intended for internal use since the davici library [1]
was created, due to all the advantages it provides (less restrictive
license, independent of any strongSwan libraries, asynchronous API).
I'd say --with-dev-headers shouldn't be used in general at all, in
particular not for distro packages, because we don't provide a stable
API for our libraries.

Regards,
Tobias

[1] https://github.com/strongswan/davici