Discussion:
[strongSwan-dev] add auto mode to HW offload
Adi Nissim
2018-03-05 16:25:53 UTC
Permalink
Hi Tobias,

I am sending patches for a new configuration to HW offload.

Up until now there were 2 modes:
1. no: Configure the SA without HW offload
2. yes: Configure the SA with HW offload.
In this case, if the device does not support offloading, SA creation will fail.

With these patches we are adding a new option:
3. auto: If the device and kernel support HW offload,
configure the SA with HW offload, but do not fail
SA creation otherwise.

We would appreciate your comments.

Thanks,
Adi
Tobias Brunner
2018-03-07 16:21:45 UTC
Permalink
Hi Adi,
Post by Adi Nissim
I am sending patches for a new configuration to HW offload.
Thanks. Please see [1], regarding the larger changes in kernel-netlink.
Also, there is an FD leak in netlink_detect_offload() (there are some
other minor things I noticed, but those I could fix when applying the
patches).

Regards,
Tobias

[1] https://wiki.strongswan.org/projects/strongswan/wiki/Contributions
Tobias Brunner
2018-03-08 09:36:27 UTC
Permalink
Hi Yevgeny,
Post by Tobias Brunner
Post by Adi Nissim
I am sending patches for a new configuration to HW offload.
Thanks. Please see [1], regarding the larger changes in kernel-netlink.
Do you mean that kernel-netlink.c changes should include the
MIT license below the existing GPL license header?
Exactly.

Regards,
Tobias

Loading...